Skip to content

tweak(commandline): Skip intro logo with -quickstart and enable -nologo, -noShellAnim in Release builds#2266

Open
xezon wants to merge 1 commit intoTheSuperHackers:mainfrom
xezon:xezon/tweak-quickstart-nologo
Open

tweak(commandline): Skip intro logo with -quickstart and enable -nologo, -noShellAnim in Release builds#2266
xezon wants to merge 1 commit intoTheSuperHackers:mainfrom
xezon:xezon/tweak-quickstart-nologo

Conversation

@xezon
Copy link

@xezon xezon commented Feb 7, 2026

This change skips the intro logo with -quickstart and enables -nologo, -noShellAnim in Release builds.

This is good for all players that want to start the game very fast.

TODO

  • Replicate in Generals

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Feb 7, 2026
@greptile-apps
Copy link

greptile-apps bot commented Feb 7, 2026

Greptile Overview

Greptile Summary

Enabled -quickstart, -nologo, and -noShellAnim command-line flags in Release builds to allow faster game startup by skipping intro videos and animations.

Key changes:

  • Removed RTS_DEBUG preprocessor guards from parseNoLogo() function, making it available in Release builds
  • Moved -nologo and -noShellAnim registration from RTS_DEBUG section to the main command-line parameter array
  • Updated parseQuickStart() to call parseNoLogo() instead of parseNoSizzle() in Release builds
  • Removed unused parseNoSizzle() function entirely (functionality now covered by parseNoLogo())
  • Added comments documenting that these flags are now available in Release builds

Impact:

  • Players using -quickstart in Release builds will now skip the EA logo intro (previously only skipped sizzle video)
  • Direct use of -nologo and -noShellAnim flags now works in Release builds
  • The TODO mentions replicating this change in the Generals codebase (currently only in GeneralsMD)

Confidence Score: 5/5
  • This PR is safe to merge with minimal risk
  • The changes are straightforward refactoring that removes build configuration guards to enable QoL features in Release builds. The removed parseNoSizzle() function is fully replaced by parseNoLogo() which sets the same flags plus additional ones, making the change functionally equivalent. No logic bugs, syntax errors, or security issues were found.
  • No files require special attention

Important Files Changed
Filename Overview
GeneralsMD/Code/GameEngine/Source/Common/CommandLine.cpp Removed RTS_DEBUG restriction from -nologo and -noShellAnim flags, removed unused parseNoSizzle function, and updated -quickstart to skip intro logo in Release builds

Sequence Diagram

 
sequenceDiagram
    participant User
    participant CommandLine
    participant parseQuickStart
    participant parseNoLogo
    participant parseNoShellMap
    participant parseNoWindowAnimation
    participant GlobalData

    User->>CommandLine: Start game with -quickstart flag
    CommandLine->>parseQuickStart: Call parseQuickStart()
    
    Note over parseQuickStart: Previously in Release builds:<br/>only called parseNoSizzle()
    Note over parseQuickStart: Now in Release builds:<br/>calls parseNoLogo() instead
    
    parseQuickStart->>parseNoLogo: Call parseNoLogo()
    parseNoLogo->>GlobalData: m_playIntro = FALSE
    parseNoLogo->>GlobalData: m_afterIntro = TRUE
    parseNoLogo->>GlobalData: m_playSizzle = FALSE
    
    parseQuickStart->>parseNoShellMap: Call parseNoShellMap()
    parseNoShellMap->>GlobalData: m_shellMapOn = FALSE
    
    parseQuickStart->>parseNoWindowAnimation: Call parseNoWindowAnimation()
    parseNoWindowAnimation->>GlobalData: m_animateWindows = FALSE
    
    Note over GlobalData: Game starts faster:<br/>- No intro logo<br/>- No sizzle video<br/>- No shell map<br/>- No window animations
Loading

@xezon xezon mentioned this pull request Feb 8, 2026
Open
3 tasks
@ViTeXFTW
Copy link

ViTeXFTW commented Feb 16, 2026

Is this legal? I can see in the additional terms in the license it says that modifications should be clearly marked - however I am not sure if we are allowed to remove the logo entirely?

@tintinhamans
Copy link

tintinhamans commented Feb 16, 2026

Is this legal? I can see in the additional terms in the license it says that modifications should be clearly marked - however I am not sure if we are allowed to remove the logo entirely?

"modified versions of the program must be marked as such and not identified as the original program."

You could also read this to mean that we have to remove such things as they might lead users to believe that this project is released by EA. But I'm no lawyer so not sure.

@xezon
Copy link
Author

xezon commented Feb 16, 2026

It is not removed. Just optionally skippable. But even disabling the video should be just fine. What makes you think we are obliged to preserve the original game exactly like it is with our modified code?

@ViTeXFTW
Copy link

ViTeXFTW commented Feb 16, 2026

Just wanted to raise the thought - but I agree that the license lean more towards making sure we do NOT market it as afilicated with EA.
From my side this look

@OmniBlade
Copy link

OmniBlade commented Feb 17, 2026

This is data related, that EA logo could be pretty much any video in modded data and i don't think we are obligated to show or not show it either way, its just an intro video as far as the code is concerned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stubbjax Stubbjax Stubbjax approved these changes

Assignees

No one assigned

Labels

Enhancement Is new feature or request Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xezon @ViTeXFTW @tintinhamans @OmniBlade @Stubbjax